feat(createProductCategoriesWorkflow): add productCategoriesCreated hook #10383
+13
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What This commit introduces the `productCategoriesCreated` hook to the `createProductCategoriesWorkflow`. It also fixes inconsistent variable names within the workflow. ### Why The hook was missing and necessary to improve the workflow's extensibility. - Variable names like `createdProducts` were misleading and did not match the context. They were updated to `createdProductCategories` for clarity. ### How Added the `productCategoriesCreated` hook and updated related logic within the workflow. - Renamed variables from `createdProducts` to `createdProductCategories` to reflect their actual purpose. Fixes: medusajs#10230
workylus
requested review from
christiananese,
carlos-r-l-rodrigues and
mrnbpt
|
|
@workylus is attempting to deploy a commit to the medusajs Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This commit introduces the
productCategoriesCreatedhook to thecreateProductCategoriesWorkflow. It also fixes inconsistent variable names within the workflow.Why
The hook was missing and necessary to improve the workflow's extensibility.
createdProductswere misleading and did not match the context. They were updated tocreatedProductCategoriesfor clarity.How
Added the
productCategoriesCreatedhook and updated related logic within the workflow.createdProductstocreatedProductCategoriesto reflect their actual purpose.Fixes: #10230